Fixes #3080 - Do not create and use jars with "tests" classifier. #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the jetty-server and jetty-servlet test-jar artifacts. The only one left is the jetty-maven-plugin test-jar. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
requested changes
Nov 25, 2020
Reinstated ServletTester in src/main/java for backwards compatibility. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
reviewed
Nov 26, 2020
| @@ -39,6 +40,51 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| /** | |||
| * <p>ServletTester should not be used.</p> | |||
There was a problem hiding this comment.
Perhaps say:
Suggested change
| * <p>ServletTester should not be used.</p> | |
| * <p>ServletTester is not best practise and may be deprecated in future releases.</p> |
gregw
reviewed
Nov 26, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletTester.java
Show resolved
Hide resolved
gregw
approved these changes
Nov 26, 2020
Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the jetty-server and jetty-servlet test-jar artifacts.
The only one left is the jetty-maven-plugin test-jar.
Signed-off-by: Simone Bordet simone.bordet@gmail.com