Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5779 Include should not set pathInContext #5780

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Dec 9, 2020

Fixes #5779 by ensuring that ContextHandler does not set pathInContext for include.

Fixes #5779 by ensuring that ContextHandler does not set pathInContext for include.
@gregw gregw requested a review from janbartel December 9, 2020 18:38
@joakime joakime added the TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) label Dec 9, 2020
@gregw
Copy link
Contributor Author

gregw commented Dec 10, 2020

CI build is Green, something has gone wrong with the link? https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/activity?branch=PR-5780

@joakime
Copy link
Contributor

joakime commented Dec 10, 2020

Build on this PR is failing ...

Could not transfer artifact javax.xml:jaxws-api:pom:2.0EA3 from/to build-master-nexus

@gregw
Copy link
Contributor Author

gregw commented Dec 10, 2020

@joakime I'm pretty sure that is unrelated!?!?!?!?

@joakime
Copy link
Contributor

joakime commented Dec 10, 2020

I think there's been some network connectivity issues on CI.
The lack of updates to github statuses, the in ability to download maven artifacts, etc ...

I restarted the last build, we'll see.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is green.
Merge it!
+1 from me.

@gregw gregw merged commit f17a5fb into jetty-10.0.x Dec 11, 2020
@gregw gregw deleted the jetty-10.0.x-5779-includePathInContext branch December 11, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include can set pathInContext
2 participants