Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove warning log message on CompressExtension failure #5790

Merged
merged 1 commit into from
Dec 18, 2020
Merged

remove warning log message on CompressExtension failure #5790

merged 1 commit into from
Dec 18, 2020

Conversation

lachlan-roberts
Copy link
Contributor

closes #5785

I think logging this failure here is redundant because we already forward the failure onto all the WriteCallbacks queued up in the Flusher anyway.

@lachlan-roberts
Issue #5785 - remove warning on CompressExtension failure
9d2e350 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
janbartel approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If indeed this is logged elsewhere, then good idea to reduce the amount of logging for the same event.

@lachlan-roberts lachlan-roberts merged commit 5611c2d into jetty-9.4.x Dec 18, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-5785-WebSocketWarning branch December 18, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@sbordet sbordet Awaiting requested review from sbordet

@gregw gregw Awaiting requested review from gregw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @janbartel