Temporary fix for challenged TCK test #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to pass the current TCK. This has been challenged in jakartaee/platform-tck#585
| if (_dispatcherType == DispatcherType.ASYNC) | ||
| { | ||
| Object async = getAttribute(AsyncContext.ASYNC_MAPPING); | ||
| if (async != null) |
There was a problem hiding this comment.
Do we really want to fall through to use the target mapping if this is null.
Should we skip the null check here and return (ServletPathMapping)async always.
There was a problem hiding this comment.
I think it is a mute point as the async mapping should never be null when the dispatch type is ASYNC... however, just in case I would prefer to return non null.
janbartel
approved these changes
Dec 14, 2020
gregw
added a commit
that referenced
this pull request
Jan 5, 2021
Revert temporary fix for challenged TCK test (#5803)
gregw
added a commit
that referenced
this pull request
Jan 27, 2021
TCK work around for #5803 Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to pass the current TCK. This has been challenged in jakartaee/platform-tck#585