Fixes #5845 - Use UTF-8 encoding for client basic auth if requested. #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduced get/setCharset in BasicAuthenticator on server-side. * Looking for the "charset" parameter on the client-side, and if there, use it. * Added test case. * Code cleanups. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Don't use unicode sequences to please CheckStyle. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Disable CheckStyle check so that the unicode sequence in the test matches that in realm.properties. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Jan 11, 2021
Comment on lines
+100
to
+104
| String value = "basic realm=\"" + _loginService.getName() + "\""; | ||
| Charset charset = getCharset(); | ||
| if (charset != null) | ||
| value += ", charset=\"" + charset.name() + "\""; | ||
| response.setHeader(HttpHeader.WWW_AUTHENTICATE.asString(), value); |
There was a problem hiding this comment.
Maybe pre compute this string rather than recreate on every request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simone Bordet simone.bordet@gmail.com