Issue #5933 ClientCertAuthenticator is not using SslContextFactory from server #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
commented
Feb 2, 2021
jetty-security/src/main/java/org/eclipse/jetty/security/DefaultAuthenticatorFactory.java
Show resolved
Hide resolved
olamy
commented
Feb 2, 2021
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
olamy
force-pushed
the
jetty-10.0.x_client_cert_auth
branch
from
1343a68
to
32672d4
Compare
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Feb 8, 2021
jetty-security/src/main/java/org/eclipse/jetty/security/DefaultAuthenticatorFactory.java
Show resolved
Hide resolved
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/eclipse/jetty/security/authentication/ClientCertAuthenticator.java
Outdated
Show resolved
Hide resolved
|
@olamy do you want me to finish this one off? |
|
@gregw new class added |
gregw
requested changes
Feb 9, 2021
There was a problem hiding this comment.
@olamy Just a few niggles left from me.
@lachlan-roberts can you have a quick look at this also with your more recent experience of authentication
jetty-security/src/main/java/org/eclipse/jetty/security/DefaultAuthenticatorFactory.java
Outdated
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/DefaultAuthenticatorFactory.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/jetty/security/authentication/ClientCertSslContextFactoryAuthenticator.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/jetty/security/authentication/ClientCertSslContextFactoryAuthenticator.java
Outdated
Show resolved
Hide resolved
gregw
approved these changes
Feb 9, 2021
Added SslClientCertAuthenticator Co-authored-by: olivier lamy <oliver.lamy@gmail.com> Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
force-pushed
the
jetty-10.0.x_client_cert_auth
branch
from
51fdc99
to
f2c9056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5933