-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6001 separate compliance modes for ambiguous URI segments, params and separators #6005
Merged
joakime
merged 2 commits into
jetty-9.4.x
from
jetty-9.4.x-6001-default-accept-ambiguous-uris
Feb 24, 2021
Merged
Fix #6001 separate compliance modes for ambiguous URI segments, params and separators #6005
joakime
merged 2 commits into
jetty-9.4.x
from
jetty-9.4.x-6001-default-accept-ambiguous-uris
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parators default modes allows both ambiguous separators and segments, but still forbids ambiguous parameters
joakime
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this.
Just going to let CI have a go at it first. (before I merge and restage)
sbordet
requested changes
Feb 24, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
approved these changes
Feb 24, 2021
@sbordet thanks for catching those! |
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6001 #4275 default modes allows both ambiguous separators and segments, but still forbids ambiguous parameters