Fix #5835 Durable filters and servlets #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
|
@janbartel nudge |
|
@janbartel re-nudge |
janbartel
requested changes
Mar 22, 2021
|
|
||
| _matchAfterIndex = (_filterMappings.length == 0 ? -1 : _filterMappings.length - 1); | ||
| // Update indexes for prepending filters |
There was a problem hiding this comment.
I don't see any code here that removes the non-durable filtermappings, yet we've set the matchBefore and matchAfter index.
update indexes after updating mapping Signed-off-by: Greg Wilkins <gregw@webtide.com>
update mappings/indexes before destroyed listeners Signed-off-by: Greg Wilkins <gregw@webtide.com>
janbartel
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup.
This replaces #5837