Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ee8 modules with sources generated from ee9 sources #8066

Merged
merged 24 commits into from
Jun 1, 2022
Merged

Add ee8 modules with sources generated from ee9 sources #8066

merged 24 commits into from
Jun 1, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented May 26, 2022 •
edited
Loading

add some modules ee8 translated from ee9:

  • jetty-ee8-annotations
  • jetty-ee8-jaas
  • jetty-ee8-nested
  • jetty-ee8-plus
  • jetty-ee8-security
  • jetty-ee8-servlet
  • jetty-ee8-servlets
  • jetty-ee8-webapp

@olamy olamy added the Build label May 26, 2022
@olamy olamy changed the base branch from jetty-10.0.x to jetty-12.0.x May 26, 2022 11:03
gregw
gregw requested changes May 27, 2022
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated sources are not in jetty format. Not in itself a big deal, but when I try to run test the checkstyle plugin complains and fails.
So either remove the plugin or preserve the formatting.

@olamy
Copy link
Member Author

olamy commented May 27, 2022

The generated sources are not in jetty format. Not in itself a big deal, but when I try to run test the checkstyle plugin complains and fails. So either remove the plugin or preserve the formatting.

Will be complicated for some parts to keep exact formatting.
So I will remove it. Sorry I was using a clean install so checkstyle do not complain same as Jenkins as checkstyle is executed before source generation.

@olamy
Copy link
Member Author

olamy commented May 27, 2022

@gregw still some issues for now with -config.jar so just use mvn test

@olamy olamy force-pushed the jetty-12.0.x-ee8 branch 2 times, most recently from 0290987 to 740c465 Compare May 30, 2022 08:26
olamy added 21 commits May 31, 2022 12:18
@olamy
start work on EE9 to EE8
b097a3e 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
finish configuration of pom for jetty-ee8-nested
1cbfd54 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add ee8 to the build
277af90 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty snapshot repo as pluginRepository
dba3d56 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add ee8-security
cdc33b5 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix copy/paste
5683643 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
jetty-ee8-servlet done as well
075c393 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty-webapp
e53c7df 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix copy resources
7f359c1 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix some resources
f1b26a8 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix some resources
05b9858 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
make class entry in web.xml more dynamic
a706ee0 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
simplify
11db36d 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty-ee8-servlets
c266764 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix reading resources
8de7c83 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
no need of jdk16 profile as we are jdk17
ba8806b 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty-ee8-jaas
6e7ead3 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty-ee8-plus
4a6872f 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
simplify poms with inheritance
d0a4837 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add comment
e99d26b 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
add jetty-ee8-annotations
a10ad54 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix jetty-ee8-annotations
c0e1678 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy
fix test for ee9 annotations
1d7f204 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
@olamy olamy marked this pull request as ready for review May 31, 2022 11:33
@olamy olamy requested a review from gregw May 31, 2022 11:37
@olamy
remove comments and fix file name
41c76bc 
Signed-off-by: Olivier Lamy <oliver.lamy@gmail.com>
gregw
gregw approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bio readouts all in the green, looks like she is alive!

@olamy olamy merged commit e7274e3 into jetty-12.0.x Jun 1, 2022
@olamy olamy deleted the jetty-12.0.x-ee8 branch June 1, 2022 03:38
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this pull request Aug 13, 2022
Merged
@olamy olamy mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
2 participants
@olamy @gregw