Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #8442 changes #8452

Closed
wants to merge 1 commit into from
Closed

Revert #8442 changes #8452

wants to merge 1 commit into from

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Aug 11, 2022 •
edited
Loading

The changes in #8442 broke the build.

@lorban
revert #8442 changes
5a417a1 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested a review from sbordet August 11, 2022 12:39
@lorban lorban self-assigned this Aug 11, 2022
@lorban lorban mentioned this pull request Aug 11, 2022
Closed
@gregw
Copy link
Contributor

gregw commented Aug 11, 2022

I think the broken build is unrelated to #8442. I think it is the favicon stuff that #8451 fixes

@gregw
Copy link
Contributor

gregw commented Aug 12, 2022

I don't think this is needed now

@gregw gregw closed this Aug 12, 2022
@joakime joakime deleted the jetty-12.0.x-8442-revert branch September 15, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet Awaiting requested review from sbordet

Assignees

@lorban lorban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorban @gregw