-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup of websocket to fix JPMS warnings #9356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Feb 15, 2023
.../jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/CoreSession.java
Outdated
Show resolved
Hide resolved
.../jetty-websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/CoreSession.java
Outdated
Show resolved
Hide resolved
...websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/util/WebSocketUtil.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/jetty/ee10/websocket/jakarta/server/config/JakartaWebSocketConfiguration.java
Show resolved
Hide resolved
...ava/org/eclipse/jetty/ee9/websocket/jakarta/server/config/JakartaWebSocketConfiguration.java
Show resolved
Hide resolved
@lachlan-roberts also,
Something related to #9327? |
this PR should also remove the work around from the OSGI manifest. |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
OSGi workaround lines to remove: ./jetty-websocket-core-common/pom.xml: ,org.eclipse.jetty.websocket.core.common.internal. |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the "export to" lines from websocket internal packages
move some classes out of the internal packages so they are now visible