Fixed FCGI content parsing. #9790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress sends the initial content in the same frame as the response headers. StreamContentParser was receiving the frame, delegating to HttpParser to parse the headers, but the buffer was still containing some content, that was lost. Now the content after the headers is correctly retained. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
Does this bug only affect 12 and not 10/11? |
lorban
approved these changes
May 22, 2023
Now a read-only version of the buffer is passed to the listener, and the original buffer is consumed as the caller expects. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
May 24, 2023
|
@lorban I verified that this is not a problem in 10/11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress sends the initial content in the same frame as the response headers. StreamContentParser was receiving the frame, delegating to HttpParser to parse the headers, but the buffer was still containing some content, that was lost. Now the content after the headers is correctly retained.