Jetty 12 graceful contexts #9867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved semantics of Callbacks to facilitate correct nesting of callbacks
sbordet
requested changes
Jun 5, 2023
jetty-core/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/ContextProvider.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/ContextHandlerTest.java
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpChannel.java
Outdated
Show resolved
Hide resolved
Reverted most changes to Callback other than cleanups Removed all shutdown mechanisms from ContextHandler
Reverted most changes to Callback other than cleanups Removed all shutdown mechanisms from ContextHandler
lorban
reviewed
Jun 5, 2023
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
requested changes
Jun 6, 2023
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpChannel.java
Outdated
Show resolved
Hide resolved
lorban
requested changes
Jun 7, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/GracefulHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Callback.java
Outdated
Show resolved
Hide resolved
lorban
approved these changes
Jun 7, 2023
sbordet
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbordet @lorban I was cleaning up TODO's in ContextHandler and saw that it didn't implement
Graceful, so I looked at theGracefulHandlerand saw that it had a bug, as it assumed a throw meant that the callback had not been called - thus a handler that completes the callback and then throws could be counted twice. Fixing that, I re-remembered the shortfalls of Callback, in that many of them are not truly atomic. So I was going to fix that just forGracefulHandlerandContextHandler, but then decided to do it for all the utility callbacks inCallback.java. I'm not 100% sold on this, but am wondering if there is actually any performance impact. @lorban can you run the perf tests on this branch to see?If we don't like the extra atomics in
Callbackthen we can just make aCallback.AtomicNestedand use it where we think it is important. But if there is no significant performance impact, may as well use it everywhere... specially as I can add some debugging to help detect double calls.