Bulletproof AbstractProxyServlet#destory() to make it easier to write #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @olamy |
garydgregory
force-pushed
the
jetty-10.0.x-better-AbstractProxyServlet-destroy
branch
from
ad3b787
to
f4986d3
Compare
gregw
requested changes
Jun 21, 2023
jetty-proxy/src/main/java/org/eclipse/jetty/proxy/AbstractProxyServlet.java
Outdated
Show resolved
Hide resolved
jetty-proxy/src/test/java/org/eclipse/jetty/proxy/AsyncMiddleManServletTest.java
Outdated
Show resolved
Hide resolved
garydgregory
force-pushed
the
jetty-10.0.x-better-AbstractProxyServlet-destroy
branch
from
f4986d3
to
2d06496
Compare
unit tests for custom subclasses of AbstractProxyServlet
garydgregory
force-pushed
the
jetty-10.0.x-better-AbstractProxyServlet-destroy
branch
from
2d06496
to
1cdf104
Compare
olamy
approved these changes
Jun 22, 2023
gregw
approved these changes
Jun 22, 2023
|
Hmm some CI failure. re-running the build.... |
|
@olamy if you are still around, any idea what is going on with CI for this one? It passes JDK11 & 19, but fails JDK17? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests for custom subclasses of AbstractProxyServlet