Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No progress during Gzip Request Inflation results in bogus error #9997

Merged
merged 3 commits into from
Jun 30, 2023
Merged

No progress during Gzip Request Inflation results in bogus error #9997

merged 3 commits into from
Jun 30, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jun 29, 2023

Eliminating no-progress checks on AsyncContentProducer (and associated testcases), as Gzip Request Inflation can (correctly) not consume in all cases.

@joakime joakime added the Bug For general bugs on Jetty side label Jun 29, 2023
@joakime joakime requested a review from lorban June 29, 2023 14:47
@joakime joakime self-assigned this Jun 29, 2023
@joakime joakime added this to the 10.0.x milestone Jun 29, 2023
@joakime joakime linked an issue Jun 29, 2023 that may be closed by this pull request
Server rejects certain sizes of streamed request bodies #9990
Closed
@joakime
Issue #9990 - GzipHttpInputInterceptor doesn't decompress properly on…
95cf1eb 
… some sized content.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime force-pushed the fix/10.0.x/gzip-input-decompress-bug branch from 2f8046f to 95cf1eb Compare June 29, 2023 14:49
@joakime joakime mentioned this pull request Jun 29, 2023
Closed
lorban
lorban previously approved these changes Jun 29, 2023
View reviewed changes
@lorban
Copy link
Contributor

lorban commented Jun 29, 2023

LGTM once the build passes.

gregw
gregw previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once it builds

@joakime
Issue #9990 - Fixing copyright header syntax
940fe5b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime dismissed stale reviews from gregw and lorban via 940fe5b June 29, 2023 16:42
@joakime
Issue #9990 - Rollback changes to GZIPContentDecoderTest
b74e27a 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested review from gregw and lorban June 29, 2023 19:27
@joakime
Copy link
Contributor Author

joakime commented Jun 29, 2023

@gregw @lorban this PR needs a re-approval, as I had followup commits.

  1. to fix the copyright header
  2. to rollback a new test in GZIPContentDecoderTest that was not necessary

@joakime joakime merged commit 17c593f into jetty-10.0.x Jun 30, 2023
@joakime joakime deleted the fix/10.0.x/gzip-input-decompress-bug branch June 30, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban approved these changes

@gregw gregw gregw approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
10.0.x
Development

Successfully merging this pull request may close these issues.

Server rejects certain sizes of streamed request bodies
3 participants
@joakime @lorban @gregw