upgrade Antora Collector; configure it to retain worktrees with Jetty Home until Antora exits #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
approved these changes
Jul 18, 2024
… Home until Antora exits
mojavelinux
force-pushed
the
upgrade-antora-collector-keep-jetty-home
branch
from
29ab8eb
to
2063c05
Compare
|
Could this be merged? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antora Collector now has a configuration option to keep temporary worktrees (in which Collector runs) until Antora exits. With this change, it's no longer necessary to rely on the Maven profile that installs Jetty Home into a directory outside the worktree. By not setting the ANTORA_CACHE_DIR environment variable, that profile will not be activated and it will just work.