Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncFS GUI should create config for case-insensitive file system on Windows. #135

Closed
pb2004 opened this issue Sep 24, 2019 · 5 comments
Closed

Comments

@pb2004
Copy link

pb2004 commented Sep 24, 2019

Currently when creating new config for encfs via gui in maingui.cpp function call is for case-sensitive file system:
nameIOIface = BlockNameIO::CurrentInterface(); //

nameIOIface = BlockNameIO::CurrentInterface();

and
nameIOIface = BlockNameIO::CurrentInterface();

For case-insensitive fs these 2 lines should call BlockNameIO::CurrentInterface() with true:
nameIOIface = BlockNameIO::CurrentInterface(true);

To Reproduce
Create new encfs dir with gui.

Expected behavior
Case-insensitive file names in encfs encrypted folder.

Desktop (please complete the following information):

  • OS: Windows 10
  • Encfs4win version: v1.10.1
  • Dokan version: v1.2.2.1000
@stale
Copy link

stale bot commented Nov 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2019
@stale stale bot closed this as completed Dec 7, 2019
@jetwhiz jetwhiz removed the wontfix label Jan 7, 2020
@jetwhiz jetwhiz reopened this Jan 7, 2020
@jetwhiz jetwhiz added the bug label Jan 7, 2020
@jetwhiz
Copy link
Owner

jetwhiz commented Jan 7, 2020

Thanks for the report, @pb2004 !

I think you're right, this should be the same as when run via command line:

encfs4win/encfs/FileUtils.cpp

Lines 1027 to 1031 in ad8367d

#if defined(__APPLE__) || defined(WIN32)
nameIOIface = BlockNameIO::CurrentInterface(true);
#else
nameIOIface = BlockNameIO::CurrentInterface();
#endif

Can you test out that change and confirm it fixes the issue on your end? You can also open a PR if you're interested in helping out!

@pb2004
Copy link
Author

pb2004 commented Jan 7, 2020

Thanks for the report, @pb2004 !

I think you're right, this should be the same as when run via command line:

encfs4win/encfs/FileUtils.cpp

Lines 1027 to 1031 in ad8367d

#if defined(__APPLE__) || defined(WIN32)
nameIOIface = BlockNameIO::CurrentInterface(true);
#else
nameIOIface = BlockNameIO::CurrentInterface();
#endif

Can you test out that change and confirm it fixes the issue on your end? You can also open a PR if you're interested in helping out!

This change fixes the reported problem. Thanks.

@jetwhiz
Copy link
Owner

jetwhiz commented Jan 13, 2020

Thanks for the confirmation, @pb2004 ! We'll include this fix in the next release

jetwhiz added a commit that referenced this issue Jan 27, 2020
@jetwhiz jetwhiz added the fixed label Jan 27, 2020
@jetwhiz
Copy link
Owner

jetwhiz commented Jan 27, 2020

This is now fixed with v1.10.2 (via bd27fcc)

@jetwhiz jetwhiz closed this as completed Jan 27, 2020
jetwhiz added a commit that referenced this issue Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants