Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google error-prone in compile step. #223

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Add google error-prone in compile step. #223

merged 2 commits into from
Nov 3, 2017

Conversation

regisd
Copy link
Member

@regisd regisd commented Nov 1, 2017

Note that FallThrough violations have been reduced to warnings.

issue #222

Note that FallThrough violations have been reduced to warnings.

issue #222
@regisd regisd added the code quality Code health and clean-up label Nov 1, 2017
@lsf37
Copy link
Member

lsf37 commented Nov 2, 2017

The test seems to have failed on something strange:
The command "mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V" failed and exited with 1

Any idea where that is from?

@regisd
Copy link
Member Author

regisd commented Nov 3, 2017

That's from:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project jflex-unicode-maven-plugin: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-compiler-plugin:3.3:compile: java.lang.UnsupportedClassVersionError: javax/tools/DiagnosticListener : Unsupported major.minor version 52.0

The error-prone plugin is compiled with Java 8, and Travis uses openjdk7. See #225

@lsf37
Copy link
Member

lsf37 commented Nov 3, 2017

Right, let me ping Travis again to see if it all works on jdk8. Could we run the plugin conditionally when jdk8 is available?

@lsf37 lsf37 closed this Nov 3, 2017
@lsf37 lsf37 reopened this Nov 3, 2017
@regisd
Copy link
Member Author

regisd commented Nov 3, 2017

So, indeed

  • 155.1 on openjdk7 fails
  • 155.2 on openjdk8 passes

@regisd regisd merged commit ad1ab52 into master Nov 3, 2017
@regisd regisd deleted the findbugs branch November 3, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code health and clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants