Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fall-through statements in Emitter #235

Merged
merged 4 commits into from
Nov 4, 2017
Merged

Add fall-through statements in Emitter #235

merged 4 commits into from
Nov 4, 2017

Conversation

regisd
Copy link
Member

@regisd regisd commented Nov 4, 2017

Add // fall through statements in switch/case.

I think this fixes the error-prone FallThrough violations (#222).

However, because of bootstrapping, the test can be re-enabled only in jflex 1.7.1 or later.

@regisd regisd merged commit 6d15369 into master Nov 4, 2017
@regisd regisd deleted the findbugs branch November 4, 2017 13:30
println(" case '\\u000B': // fall though");
println(" case '\\u000C': // fall though");
println(" case '\\u0085': // fall though");
println(" case '\\u2028': // fall though");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regisd - I know this was merged a long time ago, but "through" is consistently misspelled, FYI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@regisd regisd self-assigned this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants