Fix the build #569
Merged
Fix the build #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel doesn't accept unsafe resources; needs to be http+ssha1 or https.
added 2 commits
November 3, 2019 21:38
This is because
```
Compile, test and install all
=============================
/home/travis/build/jflex-de/jflex/cup-maven-plugin/src/main/java/jflex/maven/plugin/cup/GenerateMojo.java:5: error: cannot access BufferedReader
import java.io.BufferedReader;
^
bad class file: /modules/java.base/java/io/BufferedReader.class
class file has wrong version 55.0, should be 53.0
Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project cup-maven-plugin: Compilation failure -> [Help 1]
```
https://travis-ci.org/jflex-de/jflex/jobs/607336245?utm_medium=notification&utm_source=github_status
This reverts commit 6cb2a89. OpenJDK10 has the same error as OpenJDK9 ``` /home/travis/build/jflex-de/jflex/cup-maven-plugin/src/main/java/jflex/maven/plugin/cup/GenerateMojo.java:5: error: cannot access BufferedReader import java.io.BufferedReader; ^ bad class file: /modules/java.base/java/io/BufferedReader.class class file has wrong version 55.0, should be 53.0 Please remove or make sure it appears in the correct subdirectory of the classpath. 1 error [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project cup-maven-plugin: Compilation failure -> [Help 1] ```
Version 3.7.0 is affected on OpenJDK9 and OpenJDK10 by
```
Compile, test and install all
=============================
/home/travis/build/jflex-de/jflex/cup-maven-plugin/src/main/java/jflex/maven/plugin/cup/GenerateMojo.java:5: error: cannot access BufferedReader
import java.io.BufferedReader;
^
bad class file: /modules/java.base/java/io/BufferedReader.class
class file has wrong version 55.0, should be 53.0
Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project cup-maven-plugin: Compilation failure -> [Help 1]
```
According to https://gist.github.com/1010sachin/b4f477d7a0ab1357b39200a93186f0e8 maven-compiler-plugin version 3.8.0 is fixed.
And the configuration is much simpler wit javac plugin. https://errorprone.info/docs/installation#maven
Travis pull openjdk version "11.0.2" when I ask openjdk9.
Travis pulls openjdk version "11.0.2"
Travis default image is now Xenial and the min JDK version is openjdk8. https://docs.travis-ci.com/user/reference/xenial/
That's what Travis serves even when I request something else.
JDK11 removed javax.annotations https://blog.codefx.org/java/java-11-migration-guide/
regisd
pushed a commit
that referenced
this pull request
Nov 5, 2019
Author: Régis Décamps <regisd@google.com>
Date: Tue Nov 5 11:16:01 2019 +0100
Fix the build (#569)
* Fix #570. Build broken on Cirrus by upgrade to Bazel v1.0
* The `single_file` attribute has been replaced by `allow_single_file`.
Use **bazel_rules** v4 which fixed this. jflex-de/bazel_rules#13
* add `--incompatible_depset_union=false`
bazel_pandoc ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union bazelbuild/bazel#5817
* Use ProdriveTechnologies/bazel-latex#26 because `run_lualatex.py` is not executable
* In deps, use `https` rather than `http`
* Fix build broken on Travis due to upgrade to Xenial
* Use openjdk11 because whatever I ask for, that's what I get.
* Upgrade maven-compiler-plugin to 3.8.0 to fix _class file has wrong version 55.0, should be 53.0_
* Fix maven-compiler-plugin config for ErrorProne
* Fix config of maven-javadoc-plugin for newer JDK. https://bugs.openjdk.java.net/browse/JDK-8212233
* In aggregated sources, update to JDK8 because Xenial doesn't support JDK7 anymore.
Add manual dep on **javax-annotations.jar** because because JDK8 doesn't provide it anymore.
* Remove the task that builds the docs because `\tightlist` is not known. #571
Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single_fileattribute has been replaced byallow_single_file.Use bazel_rules v4 which fixed this. Replace
single_filebyallow_single_filebazel_rules#13--incompatible_depset_union=falsebazel_pandoc
+operator on a depset is forbidden ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union incompatible_depset_union: Disallow union operator on depsets bazelbuild/bazel#5817run_lualatex.pyis not executablehttpsrather thanhttpAdd manual dep on javax-annotations.jar because because JDK8 doesn't provide it anymore.
\tightlistis not known. [master] docs doesn't build on Travis #571