Speed up calling elm-format by not using npx
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
commented
May 29, 2021
| @@ -79,6 +79,7 @@ | |||
| "got": "^10.7.0", | |||
| "minimist": "^1.2.0", | |||
| "ora": "^5.4.0", | |||
| "path-key": "^3.1.1", | |||
There was a problem hiding this comment.
cross-spawn already depends on this module at the same version, so this is only making a sub-dependency a “real” dependency.
jfmengels
approved these changes
May 29, 2021
There was a problem hiding this comment.
This looks very good! I tried it on Ubuntu and it's working very well 👍
In my testing, the average time went from ~1550ms to ~1250ms (sometimes even less) for a single spawn of elm-format, so I'm thinking your underplayed the 200ms delay 😅
Did you mark this as draft because you haven't tested it on Windows yet? Do you have a Windows available?
|
Yes, I marked as draft since I wanted to test more first. I have Windows available, but I’m too tired to test tonight. |
|
I’ve tested on Windows now. Seems to work perfectly! |
|
Awesome, thanks a lot for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx elm-formatis used to call elm-format.npxtakes about 200 ms to boot.This PR removes the use of
npxfor elm-format, speeding things up. This is an implementation of #46 (comment) (only the elm-format bits), but done in a backwards compatible way. As a bonus, this gets rid of the command injection issue reported in #46 (but not the one inelm-review new-package).I’ve tested manually on macOS and Windows, and it seems to work just like intended. Jeroen has tested on Linux.