Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siva: implement method Get for Library and other minor changes. #1

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

mcarmonaa
Copy link
Collaborator

Signed-off-by: Manuel Carmona manu.carmona90@gmail.com

Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1 into siva will decrease coverage by 19.49%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             siva       #1      +/-   ##
==========================================
- Coverage   78.75%   59.25%   -19.5%     
==========================================
  Files           4        9       +5     
  Lines         273      540     +267     
==========================================
+ Hits          215      320     +105     
- Misses         34      180     +146     
- Partials       24       40      +16
Impacted Files Coverage Δ
siva/repository.go 55.55% <0%> (ø)
siva/location.go 45.33% <100%> (ø)
siva/library.go 65.88% <60%> (ø)
util/storer.go 0% <0%> (ø)
util/iterator.go 6.49% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debe3fe...fef65f6. Read the comment docs.

@jfontan jfontan merged commit 5dc1e73 into jfontan:siva Feb 13, 2019
@mcarmonaa mcarmonaa deleted the siva-library-get branch February 13, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants