siva testing and bug fixes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## siva #13 +/- ##
=========================================
+ Coverage 65.01% 68.5% +3.49%
=========================================
Files 13 13
Lines 786 797 +11
=========================================
+ Hits 511 546 +35
+ Misses 203 182 -21
+ Partials 72 69 -3
Continue to review full report at Codecov.
|
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
The fist init creates the siva file and the second one errors with ErrLocationNotExists. This error is now treated in Location.Has and returns false. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcarmonaa
reviewed
Feb 22, 2019
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcarmonaa
reviewed
Feb 22, 2019
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcarmonaa
approved these changes
Feb 22, 2019
jfontan
added a commit
that referenced
this pull request
May 10, 2019
siva: modify Storage to perform a custom refs management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tests for Location and fixes found while making them: