siva: add checkpoint as its own type. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
mcarmonaa
force-pushed
the
siva-factorize-checkpoint
branch
from
460d780
to
58ccef4
Compare
jfontan
reviewed
Feb 15, 2019
| // Apply applies if necessary the operations on the siva file to | ||
| // leave it in the last correct state the checkpoint keeps. | ||
| func (c *Checkpoint) Apply() error { | ||
| if c.offset > 0 { |
There was a problem hiding this comment.
I would set offset to a negative number in the previous function when there is no checkpoint file as there's a case not done here. When we start a transaction with a siva file that does not exist, the checkpoint will contain 0. This means that if we find a checkpoint with offset 0 the file must be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Carmona manu.carmona90@gmail.com