siva: location registry + transactioner #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
It's cache size is hardcoded for now until a library options is implemented. Transactions should call startTransaction and endTransaction to make sure that subsequent Location calls return the correct location. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Now transactions and registry cache size can be configured with LibraryOptions struct. Also added tests for location registry. Signed-off-by: Javi Fontan <jfontan@gmail.com>
…ransactional and write operations. Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## siva #8 +/- ##
==========================================
+ Coverage 57.85% 59.87% +2.01%
==========================================
Files 11 13 +2
Lines 700 770 +70
==========================================
+ Hits 405 461 +56
- Misses 228 236 +8
- Partials 67 73 +6
Continue to review full report at Codecov.
|
jfontan
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR joins the work done in #5 and #7 so maybe if this go ahead those PR should be closed and superseded by this one.
The transactioner coordinates transactions and write operations so there's no need to add mutexes to the
Locations.