Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type in warning message 'node_models'? #202

Closed
flcdrg opened this issue Oct 13, 2023 · 1 comment
Closed

Type in warning message 'node_models'? #202

flcdrg opened this issue Oct 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@flcdrg
Copy link
Contributor

flcdrg commented Oct 13, 2023

Describe the bug

In

log.Warn("The following dependencies will not be included in the build-info, because they are missing in the npm cache: '" + strings.Join(otherMissingDeps, ",") + "'.\nHint: Try to delete 'node_models' and/or 'package-lock.json'.")
a mention is made to "node_models". I've never heard of this, but I have heard of "node_modules". I wonder if this is a typo and it should say "node_modules"?

             log.Warn("The following dependencies will not be included in the build-info, because they are missing in the npm cache: '" + strings.Join(otherMissingDeps, ",") + "'.\nHint: Try to delete 'node_models' and/or 'package-lock.json'.")

Current behavior

Warning logged "Hint: Try to delete 'node_models' and/or 'package-lock.json'"

Reproduction steps

No response

Expected behavior

No response

Operating system type and version

Linux

@flcdrg flcdrg added the bug Something isn't working label Oct 13, 2023
flcdrg added a commit to flcdrg/build-info-go that referenced this issue Oct 13, 2023
Change term to 'node_modules' and improve grammar

Fixes jfrog#202
@flcdrg flcdrg mentioned this issue Oct 13, 2023
4 tasks
flcdrg added a commit to flcdrg/build-info-go that referenced this issue Oct 13, 2023
Change term to 'node_modules' and improve grammar

Fixes jfrog#202
@Or-Geva
Copy link
Contributor

Or-Geva commented Oct 13, 2023

Thank you for your contribution, @flcdrg. Your PR has been merged.

@Or-Geva Or-Geva closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants