Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ WriteFilesToStream() With Progress Bar #63

Merged
merged 10 commits into from
Apr 24, 2024
Merged

✨ WriteFilesToStream() With Progress Bar #63

merged 10 commits into from
Apr 24, 2024

Conversation

noyshabtay
Copy link
Contributor

@noyshabtay noyshabtay commented Apr 24, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

This PR adds WriteFilesToStreamWithProgressBar() for the use of JEM's push command. It'll probably be a temporary function thus it is marked as deprecated.

@noyshabtay noyshabtay added the ignore for release Automatically generated release notes label Apr 24, 2024
@noyshabtay noyshabtay self-assigned this Apr 24, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@noyshabtay noyshabtay marked this pull request as ready for review April 24, 2024 11:54
@noyshabtay noyshabtay merged commit b76caf9 into jfrog:dev Apr 24, 2024
6 of 7 checks passed
@noyshabtay noyshabtay deleted the progressbar branch April 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivfriedensohn yanivfriedensohn yanivfriedensohn left review comments

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

@omerzi omerzi Awaiting requested review from omerzi

@Or-Geva Or-Geva Awaiting requested review from Or-Geva

@yahavi yahavi Awaiting requested review from yahavi

Assignees

@noyshabtay noyshabtay

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noyshabtay @yanivfriedensohn