Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer config - Precheck for Docker repo names #1018

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 5, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add precheck runner for repository naming.
Usage: jf rt transfer-config <source> <target> --prechecks

The runner verifies that Docker repositories does not contain the characters . or _ and generates a CSV file with the illegal repository names, if any.

Example
Log:

2023/11/05 10:10:41 [Info] == Running check (1) 'Repositories naming' ======
2023/11/05 10:10:41 [Info] Found 2 illegal repository names. Check the summary CSV file in: /Users/yahavi/.jfrog/logs/illegal-repository-names-2023-11-05.10-10-41.csv
2023/11/05 10:10:41 [Info] Check 'Repositories naming' is done with status Fail
2023/11/05 10:10:41 [Info] == Running check (2) 'Remote repositories URL connectivity' ======
2023/11/05 10:10:41 [Info] Check 'Remote repositories URL connectivity' is done with status Success

CSV file:

RepoKey,Reason
asdas_sadas,Docker repository keys in the SasS are not allowed to include '.' or '_' characters.
asdasd.a,Docker repository keys in the SasS are not allowed to include '.' or '_' characters.

@yahavi yahavi added the improvement Automatically generated release notes label Nov 5, 2023
@yahavi yahavi requested a review from eyalbe4 November 5, 2023 09:21
@yahavi yahavi self-assigned this Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023


Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also create a PR to add "underscore" to the following limitation in https://docs.jfrog-applications.jfrog.io/jfrog-applications/jfrog-cli/cli-for-jfrog-cloud-transfer

7. Docker repositories with names that include dots aren't allowed in JFrog Cloud.

In the same documenytation link about, let's also fix the link in -

4. Run the file transfer pre-checks as described [here](https://github.com/jfrog/jfrog-cli-core/pull/1018/files).

@yahavi yahavi merged commit d1d7115 into jfrog:dev Nov 5, 2023
7 of 8 checks passed
@yahavi yahavi deleted the docker-names branch November 5, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants