Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xray usage event report #1046

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Xray usage event report #1046

merged 9 commits into from
Nov 29, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 23, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Adding back Xray event reports to be sent as default.
The issue that only admins could submit those events was fixed at v3.83 this was enforced at:
jfrog/jfrog-client-go#833

@attiasas attiasas added the ignore for release Automatically generated release notes label Nov 23, 2023
@attiasas attiasas marked this pull request as ready for review November 27, 2023 08:07
utils/usage/usage.go Outdated Show resolved Hide resolved
utils/usage/usage.go Outdated Show resolved Hide resolved
utils/usage/usage_test.go Outdated Show resolved Hide resolved
utils/usage/usage_test.go Outdated Show resolved Hide resolved
utils/usage/usage_test.go Show resolved Hide resolved
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@attiasas attiasas merged commit a15fc8e into jfrog:dev Nov 29, 2023
7 of 8 checks passed
guyshe-jfrog pushed a commit to guyshe-jfrog/jfrog-cli-core that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants