Enhancements in Output Control Options for Scan Results Writer #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
eyalbe4
changed the title
eyalbe4
approved these changes
Nov 27, 2023
attiasas
changed the title
yahavi
reviewed
Nov 28, 2023
| // The scanType (binary,dependency) | ||
| scanType services.ScanType | ||
| // Messages - Option array of messages, to be displayed if the format is Table | ||
| messages []string | ||
| } | ||
|
|
||
| func NewResultsWriter(scanResults *Results) *ResultsWriter { | ||
| return &ResultsWriter{results: scanResults} | ||
| return &ResultsWriter{results: scanResults, includeSecrets: true, writeFullScanResults: true} |
There was a problem hiding this comment.
Shouldn't the includeSecrets be false by default?
guyshe-jfrog
pushed a commit
to guyshe-jfrog/jfrog-cli-core
that referenced
this pull request
Nov 30, 2023
attiasas
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior remains unchanged; it merely introduces additional options to manage the output of the writer:
writeFullScanResults: An option to regulate whether the complete scan results should be written as a file.includeSecrets: An option to manage whether the output should include the results of the secrets scan.