Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excluding locally generated refresh tokens #934

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Sep 5, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Following the introduction of web login, the config can now consist of access and refresh tokens that were not automatically generated by the refreshable tokens mechanism.
This PR fixes the excluding logic, so that we only exclude tokens that are part of the refreshable tokens mechanism.

@RobiNino RobiNino added the bug Something isn't working label Sep 5, 2023
@RobiNino RobiNino changed the title Fix excluding only necessary tokens Fix excluding locally generated refresh tokens Sep 5, 2023
@RobiNino RobiNino merged commit 90c9d87 into jfrog:dev Sep 5, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants