Add support for NuGet Curation Audit #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
new feature
github-actions
bot
removed
the
safe to test
attiasas
added
improvement
attiasas
reviewed
Sep 5, 2024
commands/curation/curationaudit.go
Outdated
Comment on lines
757
to
763
| id = strings.TrimPrefix(id, "nuget://") | ||
| allParts := strings.Split(id, ":") | ||
| if len(allParts) != 2 { | ||
| return | ||
| } | ||
| name = allParts[0] | ||
| version = allParts[1] |
There was a problem hiding this comment.
can be replaced with SplitComponentId in utils
commands/curation/curationaudit.go
Outdated
| name = allParts[0] | ||
| version = allParts[1] | ||
|
|
||
| downloadUrls = append(downloadUrls, strings.TrimSuffix(artiUrl, "/")+"/api/nuget/v3/"+repo+"/registration-semver2/Download/"+strings.ToLower(name)+"/"+version) |
There was a problem hiding this comment.
Suggested change
| downloadUrls = append(downloadUrls, strings.TrimSuffix(artiUrl, "/")+"/api/nuget/v3/"+repo+"/registration-semver2/Download/"+strings.ToLower(name)+"/"+version) | |
| func toNugetDownloadUrl(artifactoryUrl, repo, compName, compVersion string) string { | |
| return fmt.Sprintf("%s/api/nuget/v3/%s/registration-semver2/Download/%s/%s", strings.TrimSuffix(artifactoryUrl, "/"), repo, strings.ToLower(compName), compVersion) | |
| } | |
| downloadUrls = append(downloadUrls, toNugetDownloadUrl(artUrl, repo, name, version)) |
can be extracted to func
go.mod
Outdated
| @@ -118,6 +118,6 @@ require ( | |||
|
|
|||
| // replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go dev | |||
|
|
|||
| // replace github.com/jfrog/build-info-go => github.com/jfrog/build-info-go dev | |||
| replace github.com/jfrog/build-info-go => github.com/igorz-jf/build-info-go v1.8.9-0.20240827110047-985682a6e584 | |||
There was a problem hiding this comment.
can be changed to point to dev
attiasas
approved these changes
Sep 5, 2024
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Depends on:
Add support for NuGet Curation Audit