-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build scan command output in table format #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys runs on watches) the command will print violations alone at default and will append vulnerabilities with --vuln flag
…the function to change the violation context
…n to always have violations requested
dortam888
changed the title
Fix build scan command that didn't print without flags.
Fix build scan command output in table format
Sep 10, 2024
dortam888
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 10, 2024
attiasas
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Fix build scan command to always have violation context as the build scan API is running on build watches and intend to return violations. Also dropped all build hasViolationContext functions.
Additionally, Dropped additional printing in the table format that made the command print the vulnerability table twice.