-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to control the depth of the pnpm dependency tree #202
base: dev
Are you sure you want to change the base?
Conversation
Poetry: components.NewBoolFlag(Poetry, "Set to true to request audit for a Poetry project."), | ||
Go: components.NewBoolFlag(Go, "Set to true to request audit for a Go project."), | ||
DepType: components.NewStringFlag(DepType, "[npm] Defines npm dependencies type. Possible values are: all, devOnly and prodOnly."), | ||
MaxTreeDepth: components.NewStringFlag(MaxTreeDepth, "[pnpm] Max depth of the generated dependencies tree for SCA scan.", components.WithStrDefaultValue("Infinity")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only pnpm?
isn't it relevant for npm? other technologies?
If it's a flag specific for a technologies - I'd add its name to the flag, like PnpmMaxTreeDepth
(same with DepType
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now it's specific for pnpm
, we can extend its usage later, changing the description is easier than changing the flag itself.
DepType
could also be used for multiple techs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flag name + dotnet version
dev
branch.go vet ./...
.go fmt ./...
.PNPM improvements