Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exclude pattern when building dotnet dependency tree #24

Merged
merged 11 commits into from
Feb 25, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Feb 18, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Use the exclude pattern to exclude sub-projects for dotnet when building its dependency tree.
Depends on:
jfrog/build-info-go#233
jfrog/jfrog-cli-core#1131

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 20, 2024
@attiasas attiasas requested a review from yahavi February 20, 2024 10:03
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 20, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 21, 2024
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fixes suggested

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 25, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 25, 2024
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@attiasas attiasas merged commit cc8b9f3 into jfrog:dev Feb 25, 2024
8 checks passed
@attiasas attiasas deleted the exclude_nuget_project branch February 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants