New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curation mvn enabled #31

Merged

attiasas merged 8 commits into jfrog:dev from asafambar:curation_mvn_enabled

Mar 3, 2024

Contributor

asafambar commented Feb 25, 2024 •

edited by attiasas

Loading

The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....
All static analysis checks passed.
All tests have passed. If this feature is not already covered by the tests, new tests have been added.
All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on: jfrog/jfrog-cli-core#1138

asafambar added 2 commits

February 25, 2024 17:18


          enable mvn curation support by version of artifactory and xray.

b6a5686


          Merge remote-tracking branch 'upstream/dev' into curation_mvn_enabled

ba736a2

asafambar had a problem deploying to frogbot

February 25, 2024 15:26

— with

GitHub Actions Failure

Contributor Author

asafambar commented Feb 25, 2024 •

edited

Loading

This PR enable curation support for maven according to xray and artifactory version, it also keep the option to enable it by env var
updated documentation:
jfrog/documentation#93


          add test

f39223f

asafambar had a problem deploying to frogbot

February 26, 2024 16:16

— with

GitHub Actions Failure


          add test

1bec57a

asafambar had a problem deploying to frogbot

February 26, 2024 16:19

— with

GitHub Actions Failure

attiasas added improvement safe to test labels

github-actions bot removed the safe to test label

attiasas requested changes

View reviewed changes

commands/curation/curationaudit.go Outdated Show resolved Hide resolved

commands/curation/curationaudit.go Outdated Show resolved Hide resolved

commands/curation/curationaudit.go Show resolved Hide resolved

commands/curation/curationaudit.go

+              	if err != nil {
+              		return
+              	}
+              	rtManager, err = rtUtils.CreateServiceManager(serverDetails, 2, 0, false)

Contributor

attiasas Feb 28, 2024

Refactor values as consts.

Contributor Author

asafambar Feb 28, 2024

This is not a matter of consts in my opinion, thats what the function want, just read its signature

commands/curation/curationaudit_test.go Outdated Show resolved Hide resolved

attiasas added the safe to test label

github-actions bot removed the safe to test label


          CR and testsFixes

36476a8

asafambar had a problem deploying to frogbot

February 28, 2024 14:10

— with

GitHub Actions Failure

asafambar added the safe to test label

github-actions bot removed the safe to test label

asafambar added the safe to test label

github-actions bot removed the safe to test label


          Fix test

703b853

asafambar had a problem deploying to frogbot

February 28, 2024 17:20

— with

GitHub Actions Failure

asafambar added the safe to test label

github-actions bot removed the safe to test label


          Fix test

0d37f33

asafambar had a problem deploying to frogbot

February 29, 2024 09:54

— with

GitHub Actions Failure

asafambar added the safe to test label

github-actions bot removed the safe to test label


          fix go mod

e45d489

asafambar temporarily deployed to frogbot

March 3, 2024 10:17

— with

GitHub Actions Inactive

attiasas added the safe to test label

github-actions bot removed the safe to test label

github-actions bot commented Mar 3, 2024

🐸 JFrog Frogbot

attiasas merged commit d82ecc0 into jfrog:dev

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels