Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all config commands - atomic #1470

Merged
merged 40 commits into from
Jun 12, 2022
Merged

Make all config commands - atomic #1470

merged 40 commits into from
Jun 12, 2022

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Mar 9, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

following jfrog/jfrog-cli-core#352 and jfrog/jfrog-cli-core#350

@sverdlov93
Add TestConfigConcurrency
117c358 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into config-…
d6bcbc4 
…concurrency-test
@sverdlov93 sverdlov93 requested a review from eyalbe4 March 9, 2022 16:00
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Mar 9, 2022
@sverdlov93
Add TestConfigConcurrency
7d29ac3 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Add TestConfigConcurrency
a181fd2 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 9, 2022
@sverdlov93
Add TestConfigConcurrency
df6ab71 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 9, 2022
@sverdlov93
Add TestConfigConcurrency
8397271 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 9, 2022
@sverdlov93
Add TestConfigConcurrency
2aadc32 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Update tests.yml
274ff44
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into config-…
c877acd 
…concurrency-test

� Conflicts:
�	.github/workflows/tests.yml
@sverdlov93
Add TestConfigConcurrency
c11e8b2 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Merge branch 'config-concurrency-test' of https://github.com/sverdlov…
95b196e 
…93/jfrog-cli into config-concurrency-test

� Conflicts:
�	.github/workflows/tests.yml
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 10, 2022
@sverdlov93
Add TestConfigConcurrency
bdde66f 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 10, 2022
@sverdlov93
Add TestConfigConcurrency
b248b29 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 10, 2022
@sverdlov93
Add TestConfigConcurrency
7d52666 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
merge dev
ad9a7f2 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 31, 2022
@sverdlov93
merge dev
a470699 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 31, 2022
@sverdlov93
merge dev
ba0192d 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
merge dev
e6a4594 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into config-…
a57e87c 
…concurrency-test

� Conflicts:
�	go.mod
�	go.sum
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 12, 2022
@sverdlov93
remove logs
c1a1729 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 12, 2022
@sverdlov93
update go.mod
eeab612 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 12, 2022
@sverdlov93
update go.mod
d60da1f 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request bug Something isn't working and removed safe to test Approve running integration tests on a pull request labels Jun 12, 2022
@sverdlov93 sverdlov93 merged commit a17cbb3 into jfrog:dev Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4