Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that Xray URL exists when running Xray commands #2238

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Validate that Xray URL exists when running Xray commands #2238

merged 3 commits into from
Oct 4, 2023

Conversation

sverdlov93
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@sverdlov93
fix latest build
a495e0b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@sverdlov93
fix latest build
ea9a62f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
talarian1
talarian1 reviewed Oct 4, 2023
View reviewed changes
scan/cli.go Outdated Show resolved Hide resolved
@sverdlov93
fix latest build
27ec8e8 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit fbe1eb3 into jfrog:dev Oct 4, 2023
10 of 11 checks passed
@yahavi yahavi added the improvement Automatically generated release notes label Oct 4, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 left review comments

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sverdlov93 @yahavi @talarian1