Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary files in npm installer #2246

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Remove unnecessary files in npm installer #2246

merged 1 commit into from
Oct 5, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 5, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Currently, most of the npm installer includes the nodejs files:
image

@yahavi yahavi added the bug Something isn't working label Oct 5, 2023
@yahavi yahavi self-assigned this Oct 5, 2023
@yahavi yahavi merged commit eb0719e into jfrog:dev Oct 5, 2023
27 of 28 checks passed
@yahavi yahavi deleted the npm-diet branch October 5, 2023 15:09
@BrewTestBot BrewTestBot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @sverdlov93