Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running npm install without package.json #2269

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 18, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on:

Allow running jf npm install <package-name> when there is no package.json existing in the working directory.

@yahavi yahavi added the improvement Automatically generated release notes label Oct 18, 2023
@yahavi yahavi requested a review from eyalbe4 October 18, 2023 13:44
@yahavi yahavi self-assigned this Oct 18, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 18, 2023
@yahavi yahavi temporarily deployed to frogbot October 18, 2023 13:45 — with GitHub Actions Inactive
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 18, 2023
@github-actions
Copy link
Contributor


@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 19, 2023
@yahavi yahavi merged commit 187ca70 into jfrog:dev Oct 19, 2023
64 of 66 checks passed
@yahavi yahavi deleted the no-package-json branch October 19, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants