Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipenv tests #2322

Merged
merged 5 commits into from
Nov 26, 2023
Merged

Fix pipenv tests #2322

merged 5 commits into from
Nov 26, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 20, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on: jfrog/build-info-go#213

@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Nov 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@attiasas attiasas changed the title Fix Python tests Fix pipenv tests Nov 20, 2023
eyalbe4
eyalbe4 requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that the Lifecycle tests are failing on this PR. Let's fix before merging this PR.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@attiasas attiasas merged commit d807968 into jfrog:dev Nov 26, 2023
62 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attiasas @eyalbe4 @yahavi