-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFrog Curation - Support "Implicit curation" - Run curation after "install" command failure #2639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does jfrog-cli-security include a mechanism to check whether the user has JFrog Curation enabled, and if so skip the execution for the "jf curation-audit" command?
answer:
yes
buildtools/cli.go
Outdated
cmdName, _ := getCommandName(c.Args()) | ||
return npmGenericCmd(c, cmdName, false) | ||
if errFromCmd = npmGenericCmd(c, cmdName, false); errFromCmd != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if statement that checks whether the error is nil or not should be placed inside the jfrog-cli-security module. This is to reduce the dependecy of jfrog-cli-security on this module, in case changes are needed to the curation logic.
The approach taken for "pip" is better, so let's adopt it here as well -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a bit more complicated for npm, I will check again
dev
branch.go vet ./...
.go fmt ./...
.