Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JFrog Curation - Support "Implicit curation" - Run curation after "install" command failure #2639

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

asafambar
Copy link
Collaborator

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@asafambar asafambar changed the base branch from v2 to dev August 5, 2024 14:55
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Aug 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 5, 2024
buildtools/cli.go Outdated Show resolved Hide resolved
buildtools/cli.go Outdated Show resolved Hide resolved
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Aug 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 7, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Aug 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 13, 2024
@asafambar asafambar changed the title Implicit curation support Implicit curation support - Run curation after "install" command failure Aug 13, 2024
@asafambar asafambar changed the title Implicit curation support - Run curation after "install" command failure support "Implicit curation" - Run curation after "install" command failure Aug 13, 2024
@eyalbe4 eyalbe4 changed the title support "Implicit curation" - Run curation after "install" command failure JFrog Curation - Support "Implicit curation" - Run curation after "install" command failure Aug 19, 2024
@eyalbe4 eyalbe4 added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Aug 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 19, 2024
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does jfrog-cli-security include a mechanism to check whether the user has JFrog Curation enabled, and if so skip the execution for the "jf curation-audit" command?

answer:
yes

cmdName, _ := getCommandName(c.Args())
return npmGenericCmd(c, cmdName, false)
if errFromCmd = npmGenericCmd(c, cmdName, false); errFromCmd != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement that checks whether the error is nil or not should be placed inside the jfrog-cli-security module. This is to reduce the dependecy of jfrog-cli-security on this module, in case changes are needed to the curation logic.
The approach taken for "pip" is better, so let's adopt it here as well -
image

Copy link
Collaborator Author

@asafambar asafambar Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a bit more complicated for npm, I will check again

@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@eyalbe4 eyalbe4 merged commit e6e3c17 into jfrog:dev Aug 29, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants