Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project key to GetAllRepositoriesFiltered #1007

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Add project key to GetAllRepositoriesFiltered #1007

merged 8 commits into from
Aug 27, 2024

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Aug 20, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

With this PR, all repositories for a specific project can be retrieved. It uses the current GetAllRepositoriesFiltered function with the project key added as a parameter.

Fixes #812

@Or-Geva Or-Geva added the new feature Automatically generated release notes label Aug 20, 2024
@Or-Geva Or-Geva requested a review from yahavi August 20, 2024 15:39
@Or-Geva Or-Geva mentioned this pull request Aug 20, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@Or-Geva Or-Geva linked an issue Aug 21, 2024 that may be closed by this pull request
GetAllRepositoriesFiltered(params services.RepositoriesFilterParams) should honor the API #812
Closed
@Or-Geva Or-Geva self-assigned this Aug 21, 2024
yahavi
yahavi requested changes Aug 21, 2024
View reviewed changes
artifactory/services/repositories.go Outdated Show resolved Hide resolved
artifactory/services/repositories.go Outdated Show resolved Hide resolved
artifactory/services/repositories.go Outdated Show resolved Hide resolved
artifactory/services/repositories_test.go Outdated Show resolved Hide resolved
artifactory/services/repositories_test.go Outdated Show resolved Hide resolved
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@Or-Geva Or-Geva merged commit de462dc into dev Aug 27, 2024
25 of 26 checks passed
@Or-Geva Or-Geva mentioned this pull request Aug 28, 2024
Merged
4 tasks
@Or-Geva Or-Geva mentioned this pull request Aug 28, 2024
Closed
4 tasks
@yahavi yahavi deleted the project branch August 30, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@yahavi yahavi yahavi requested changes

Assignees

@Or-Geva Or-Geva

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetAllRepositoriesFiltered(params services.RepositoriesFilterParams) should honor the API
3 participants
@Or-Geva @yahavi @sverdlov93