Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remote repository numeric fields to pointers to avoid omitting #834

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Sep 28, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Convert int fields to *int to avoid them not being sent if the number is 0

SocketTimeoutMillis               *int                    `json:"socketTimeoutMillis,omitempty"`
RetrievalCachePeriodSecs          *int                    `json:"retrievalCachePeriodSecs,omitempty"`
MetadataRetrievalTimeoutSecs      *int                    `json:"metadataRetrievalTimeoutSecs,omitempty"`
MissedRetrievalCachePeriodSecs    *int                    `json:"missedRetrievalCachePeriodSecs,omitempty"`
UnusedArtifactsCleanupPeriodHours *int                    `json:"unusedArtifactsCleanupPeriodHours,omitempty"`
AssumedOfflinePeriodSecs          *int                    `json:"assumedOfflinePeriodSecs,omitempty"`

should fix jfrog/jfrog-cli#2172

Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 28, 2023
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the bug Something isn't working label Sep 28, 2023
@sverdlov93 sverdlov93 merged commit 622034e into jfrog:dev Sep 28, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote repository creation completely ignores certain fields
2 participants