Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on 3.1.11.1 #9589

Closed
ncfavier opened this issue Mar 19, 2024 · 1 comment
Closed

Tests failing on 3.1.11.1 #9589

ncfavier opened this issue Mar 19, 2024 · 1 comment
Labels

Comments

@ncfavier
Copy link

        lhs to normal:                                               FAIL (0.05s)

          ------------------------------------------------------------------------
          --- lhs-test.html
          +++ /build/pandoc-3.1.11.1/dist/build/test-pandoc/test-pandoc --emulate --quiet lhs-test.native --wrap=preserve -r native -s --markdown-headings=setext -w html
          + 182     pre > code.sourceCode > span { display: inline-block; text-indent: -5em; padding-left: 5em; }
          - 182     pre > code.sourceCode > span { text-indent: -5em; padding-left: 5em; }
          ------------------------------------------------------------------------
          Use -p '/html.writer.lhs to normal/' to rerun this test only.
        lhs to lhs:                                                  FAIL (0.30s)

          ------------------------------------------------------------------------
          --- lhs-test.html+lhs
          +++ /build/pandoc-3.1.11.1/dist/build/test-pandoc/test-pandoc --emulate --quiet lhs-test.native --wrap=preserve -r native -s --markdown-headings=setext -w html+lhs
          + 182     pre > code.sourceCode > span { display: inline-block; text-indent: -5em; padding-left: 5em; }
          - 182     pre > code.sourceCode > span { text-indent: -5em; padding-left: 5em; }
          ------------------------------------------------------------------------
          Use -p '/html.writer.lhs to lhs/' to rerun this test only.
@ncfavier ncfavier added the bug label Mar 19, 2024
ncfavier added a commit to NixOS/nixpkgs that referenced this issue Mar 19, 2024
@jgm
Copy link
Owner

jgm commented Mar 19, 2024

This is probably because you're compiling pandoc against a more recent version of skylighting than was available at the time 3.1.11.1 was released. If this is a problem, you can constrain to the lowest version of skylighting compatible with 3.1.11.1's version bound. (Or, better, just upgrade to 3.1.12.3, the current version.)

I will consider getting rid of these tests or making pandoc's version constraint for skylighting tighter in the future.

@jgm jgm closed this as completed Mar 19, 2024
jgm added a commit that referenced this issue Mar 19, 2024
This will avoid test failures due to minor changes in
skylighting versions, e.g. #9589.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants