Fixed issues in transfering file in binary mode #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation is based on vGetContents which does not work if the binary file contain byte sequence that could not be decoded into [Char]. The new implementation is based on vGetBuf which works for binary data.
I implemented genericTransmitString based on genericTransmitHandle, hence could remove the usage of rtransmitString.
cmd_stor has similar issue with cmd_retr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
I was to implement some FTP server thing and found ftphs. But I found transferring files in binary mode didn't work in my environment(CentOS 6.4). This is because vGetContents/hGetContents does not work with binary files if the byte sequence could not be decoded into Char. So I tried to fix it and here is the result, please take a look. Thanks.
P.S. I tried to follow the coding style carefully, but I am a Haskell newbie, there might be some non-idiomatic code.
Regards,
Ken