Pass --ignore-installed and other flags to pip install

[petobens]

Is there a way to pass the --ignore-installed flag? If there isn't can you add the feature? Thanks!

[jgonggrijp]

Currently, pip-review passes all arguments it doesn't recognise to pip list but not to pip install (to which the --ignore-installed flag belongs). So no, currently there is no way to do that.

Adding it is not trivial. Naievely, we could try to just pass all unknown options both to pip list and to pip install, but that wouldn't work because there are several options to pip list that pip install doesn't recognize and vice versa. So we'd need a clever way to distinguish options that should be forwarded to pip list from options that should be forwarded to pip install. We could hardcode some options, but I'm not a fan of that. Suggestions welcome.

[petobens]

Ok. Will set the option through the pip config file in the mean time. Thanks for the quick reply.

[jgonggrijp]

I think I want to go for a compromise: hardcode a set of options that is recognized by pip list but not by pip install and vice versa. Pass those options only to the respective pip command. Pass all other unrecognized options to both.

This approach would mostly fix bugs, especially with the --user flag, but it may also cause unexpected behaviour in some cases. Technically, it is a breaking change. Opinions welcome: should I leave this for the 2.0 release, or could it be in a 1.x release?

[bobzomer]

To avoid breaking change, we could add two new specific options:

• --install_only_parameters: All the parameters after this will be sent to install only
• --common_parameters: All the parameters after this will be sent to both list and install
  Without these parameters, the unknown parameters are sent to list only => we keep a full backward compatibility.

[jgonggrijp]

@bobzomer Clever! But isn't that a bit long-winded? If somebody is using the --user flag, they'll have to choose between two evils:

• pip-review -i --user, which is broken, or
• pip-review -i --common_parameters --user, which is rather long to type.

I imagine such users would happily accept a little bit of breaking change so they can have a short command that works correctly.

[tan-wei]

Waiting for the update which makes --user more useful.

[jgonggrijp]

@tan-wei @bobzomer @petobens @joshbode @mihaic @HaleTom @x-ji @cjbassi @dimitry-ishenko @Konfekt This should be solved in version 1.1.0. Please install the update and report back here if there is still something not working.

Also, I'm looking for somebody to take over. See #76.

[tan-wei]

Thanks. I can confirm it works well on Manjaro now.