Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override is-rounded with button-small. Fixes #3163. #3208

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

raineorshine
Copy link
Contributor

This is a bugfix for #3163.

Proposed solution

button-small currently assumes the button is not rounded and overrides its border-radius from $radius to $radius-small. This is not valid however if is-rounded is applied to the button.

This PR adds &:not(.is-rounded) to avoid this. This solution is preferable to #3164 which uses !important.

Tradeoffs

None

Testing Done

Tested with the following code:

<p>This button should be small and rounded:</p>
<div class="buttons are-small">
  <button class="button is-rounded">Hello</button>
</div>

Bulma v0.9.1 incorrectly renders the button not rounded. Test and confirmed that this PR causes the button to be correctly rendered small and rounded.

Changelog updated?

No.

@jgthms jgthms merged commit 529cac1 into jgthms:master Dec 20, 2020
@jgthms
Copy link
Owner

jgthms commented Dec 20, 2020

Thanks, I like this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants