Fix case insensitive relation type comparison for has and get #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csarven
force-pushed
the
fix/case-insensitive-relation-type-comparison
branch
from
b46f148
to
80ff775
Compare
|
Good catch, thanks! Published in |
|
Thanks for the quick review! I'm glad the minor code I contributed at 3-4 in the morning turned out okay... while I was in a rabbit hole trying to replace the homebaked Link header parser in dokieli :) |
|
Wow, what a massive project! Wasn't aware something like it existed, going to have to play around with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case-insensitive comparison is required as per RFC8288, Sections 2.1.1, 2.1.2 for relation types.
While case insensitive comparison is working as intended for the retrieval shorthand (
rel), it was not for lookup (has) or retrieving (get). This PR fixes that and includes the tests.