Skip to content

Commit

Permalink
fix jhipster v7.4.x compatibility and prettier differences
Browse files Browse the repository at this point in the history
  • Loading branch information
ruddell committed Dec 7, 2021
1 parent 0ede59f commit dfe6d4b
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
jhipster_version: [7.3.1, 6]
jhipster_version: [7, 6]
node_version: [14.x]
app_type:
- JwtDtoWebsocketsApp
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
strategy:
fail-fast: false
matrix:
jhipster_version: [7.3.1]
jhipster_version: [7]
node_version: [14.x]
app_type:
- JwtDtoApp
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sample-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
jhipster_version: [7.3.1]
jhipster_version: [7]
node_version: [14.15.0]
os: [ubuntu-latest]
env:
Expand Down
9 changes: 1 addition & 8 deletions generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@ const {

module.exports = class extends AppGenerator {
constructor(args, opts) {
super(args, { fromBlueprint: true, ...opts }); // fromBlueprint variable is important

const jhContext = (this.jhipsterContext = this.options.jhipsterContext);

if (!jhContext) {
this.error(`This is a JHipster blueprint and should be used only like ${chalk.yellow('jhipster --blueprints react-native')}`);
}
super(args, { fromBlueprint: true, skipClient: false, ...opts }); // fromBlueprint variable is important

this.patchInFile = patchInFile.bind(this);
if (!this.context) {
Expand All @@ -36,7 +30,6 @@ module.exports = class extends AppGenerator {
// this does not look to be configurable from blueprints (see getPrettierExtensions in generator-base.js)
// skipClient has no effect for generator-jhipster-react-native since it only generates a client
this.skipClient = false;
this.jhipsterConfig.skipClient = false;
}

get initializing() {
Expand Down
1 change: 0 additions & 1 deletion generators/entity/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ module.exports = class extends EntityGenerator {
// this does not look to be configurable from blueprints (see getPrettierExtensions in generator-base.js)
// skipClient has no effect for generator-jhipster-react-native since it only generates a client
this.skipClient = false;
this.jhipsterConfig.skipClient = false;
}

get initializing() {
Expand Down
64 changes: 52 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dfe6d4b

Please sign in to comment.